DeprecationWarning: router argument is deprecated

[rob-blackbourn]

Fantastic project!

I have a project aiohttp-route-middleware which uses the router parameter on the aiohttp.web.Application class constructor.

from aiohttp import web
from aiohttp_route_middleware import UrlDispatcherEx
app = web.Application(router=UrlDispatcherEx())

I've just noticed this parameter has become deprecated.

What should I do instead?

Thanks,

Rob

[aio-libs-bot]

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #1108 (Deprecate aiohttp.wsgi), #1615 (Chunk size is deprecated), #1137 (Improve router performance), #986 (Implement router shortcuts), and #3260 (Deprecate stream.unread_data).

[asvetlov]

If you need some pre and post processing for specific web-handler -- please do it explicitly.
There are many techniques: direct calls, function decorators etc.
Middlewares are supposed to work on application level; this design is common for very many HTTP frameworks -- doesn't matter if these frameworks are async or not.

[rob-blackbourn]

Hi @asvetlov,

There good thing about standards is there are so many to choose from :)

The way aiohttp does middleware is very much like ASP.Net core, but this has the limitations I discuss in the README of my project (but maybe I have just misunderstood?).

I was trying to achieve one of the patterns expressjs supports: routed middleware.

I can certainly find a work-around (I guess a decorator would be quite elegant), but it would be a shame to loose this feature. What is the motivation for deprecating it?

Rob

[asvetlov]

Please read #2766

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.