Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: host parameter for aiohttp_server fixture #3671

Closed
ykvch opened this issue Mar 28, 2019 · 3 comments
Closed

Feature request: host parameter for aiohttp_server fixture #3671

ykvch opened this issue Mar 28, 2019 · 3 comments
Labels
documentation Improvements or additions to documentation outdated

Comments

@ykvch
Copy link

ykvch commented Mar 28, 2019

Long story short

To test client connection to multiple hosts. The proposed fixture is aiohttp_server.
Unfortunately it accepts only port parameter.

Expected behaviour

host parameter added to and passed over to TestServer (same as port) here:
https://github.com/aio-libs/aiohttp/blob/master/aiohttp/pytest_plugin.py#L240-L241

Actual behaviour

No host parameter

@aio-libs-bot
Copy link

GitMate.io thinks the contributor most likely able to help you is @asvetlov.

Possibly related issues are #3290 (Missing raise_for_status parameter to aiohttp.request), #689 ([Feature Request] Provide a JsonResponse class), #1861 (Client request timeout parameters are inconsistent), #3090 (Remove reader parameter from request.multipart()), and #1965 (Feature request: accept a set of fingerprints in TCPConnector).

@aio-libs-bot aio-libs-bot added the documentation Improvements or additions to documentation label Mar 28, 2019
@asvetlov
Copy link
Member

I suggest implementing your own fixture which can do everything you need.
aiohttp_server covers a server executed on local host only.

@ykvch
Copy link
Author

ykvch commented Apr 25, 2019

Got it, thanks.

@ykvch ykvch closed this as completed Apr 25, 2019
@lock lock bot added the outdated label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation outdated
Projects
None yet
Development

No branches or pull requests

3 participants