Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sendfile in StaticHandler #398

Closed
asvetlov opened this issue Jun 5, 2015 · 5 comments
Closed

Use sendfile in StaticHandler #398

asvetlov opened this issue Jun 5, 2015 · 5 comments
Labels
outdated

Comments

@asvetlov
Copy link
Member

asvetlov commented Jun 5, 2015

see tornadoweb/tornado#1448
@GomZik
Copy link

GomZik commented Jul 8, 2015

Can I try to make this task?

@asvetlov
Copy link
Member Author

asvetlov commented Jul 8, 2015

Please do. But keep in mind:

  1. RANGE support Support Content-Range/Last-Modified/ETag in aiohttp.web static handling #165 should be implemented first
  2. sendfile should be optional, if the function is not supported by platform (e.g. Windows) fallback to conventional way.

@asvetlov asvetlov mentioned this issue Sep 13, 2015
Closed
@jashandeep-sohi
Copy link
Contributor

I'm working on this in #503. Feedback welcome.

@jashandeep-sohi jashandeep-sohi mentioned this issue Sep 13, 2015
Merged
@asvetlov
Copy link
Member Author

Fixed by #503

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@asvetlov @GomZik @jashandeep-sohi