-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 3.5 #4046
Conversation
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@asvetlov FYI I've rebased this |
@@ -10,8 +10,8 @@ | |||
from setuptools import Extension, setup | |||
|
|||
|
|||
if sys.version_info < (3, 5, 3): | |||
raise RuntimeError("aiohttp 3.x requires Python 3.5.3+") | |||
if sys.version_info < (3, 6): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay to just remove this check since setuptools that supports python_requires
is shipped with Python 3.6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to fail loudly even on Python 3.5
I've triggered a full matrix build for this branch now: https://travis-ci.com/aio-libs/aiohttp/builds/126532209 |
Thanks. |
The failure source is different behavior of yarl quoting/unquoting for cythonized and pure python versions |
The failure reason is a different behavior of pure python and cythonized yarl versions. |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply cfb40b7 on top of patchback/backports/3.9/cfb40b7282ce41d10fcfc2021992808760f9bf6e/pr-4046 Backporting merged PR #4046 into master
🤖 @patchback |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply cfb40b7 on top of patchback/backports/3.8/cfb40b7282ce41d10fcfc2021992808760f9bf6e/pr-4046 Backporting merged PR #4046 into master
🤖 @patchback |
(cherry picked from commit cfb40b7)
(cherry picked from commit cfb40b7)
Fixes #3947