Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure web & client files into separate packages #509

Closed
jashandeep-sohi opened this issue Sep 15, 2015 · 5 comments
Closed

Restructure web & client files into separate packages #509

jashandeep-sohi opened this issue Sep 15, 2015 · 5 comments
Labels

Comments

@jashandeep-sohi
Copy link
Contributor

This is more of cosmetic issue/question rather than a functional one, but what do you think about restructuring web & client files into separate packages?
i.e. aiohttp/client/__init__.py & aiohttp/web/__init__.py

@asvetlov
Copy link
Member

Why?
Your cosmetic change breaks backward compatibility BTW

@jashandeep-sohi
Copy link
Contributor Author

Why?

For the same reason why all the code isn't in a single file: better organization & separation.
Most of the aiohttp.web files already have a web_ prefix, but this would just be a more Pythonic way of splitting it.

Your cosmetic change breaks backward compatibility BTW

True, but only for the people explicitly importing the modules i.e. import aiohttp.websocket_client. All the other API should work fine by exporting the proper symbols in aiohttp/__init__.py.

@asvetlov
Copy link
Member

Well, if you import all public names from __init__.py only why do you care?
Anyway, the ship has sailed.

@jashandeep-sohi
Copy link
Contributor Author

Fair enough.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants