-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing slots to _RequestContextManager
and _WSRequestContextManager
#5329
Add missing slots to _RequestContextManager
and _WSRequestContextManager
#5329
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5329 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 41 41
Lines 8739 8739
Branches 1402 1402
=======================================
Hits 8491 8491
Misses 129 129
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
…anager` (#5329) * Add missing slots to context managers * Fix CONTRIBUTORS.txt * Add notes to CHANGES * Fix CONTRIBUTORS.txt
💚 Backport successfulThe PR was backported to the following branches:
|
…anager` (aio-libs#5329) * Add missing slots to context managers * Fix CONTRIBUTORS.txt * Add notes to CHANGES * Fix CONTRIBUTORS.txt
…anager` (aio-libs#5329) * Add missing slots to context managers * Fix CONTRIBUTORS.txt * Add notes to CHANGES * Fix CONTRIBUTORS.txt
It seems that slots were forgotten in children of
_BaseRequestContextManager
PR adds slots to
_RequestContextManager
and_WSRequestContextManager
Here is a very short sample to show the diff:
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.