-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop installing cchardet speedup under >Python 3.9 #6857
Stop installing cchardet speedup under >Python 3.9 #6857
Conversation
`cchardet` stopped being maintained a while ago so this patch removes it from the `speedups` extra to keep it helpful. It also makes the same adjustment in the CI under the most recent CPython versions to keep the testing going. Refs: * aio-libs#6819 (comment) * PyYoshi/cChardet#77
Codecov Report
@@ Coverage Diff @@
## master #6857 +/- ##
===========================================
+ Coverage 21.76% 93.44% +71.68%
===========================================
Files 104 104
Lines 30628 30629 +1
Branches 3064 3076 +12
===========================================
+ Hits 6666 28622 +21956
+ Misses 23859 1838 -22021
- Partials 103 169 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1e8c40f on top of patchback/backports/3.8/1e8c40fe48245247f63549ebe119a6f309614889/pr-6857 Backporting merged PR #6857 into master
🤖 @patchback |
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 1e8c40f on top of patchback/backports/3.9/1e8c40fe48245247f63549ebe119a6f309614889/pr-6857 Backporting merged PR #6857 into master
🤖 @patchback |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #6861 🤖 @patchback |
Backport to 3.8: 💚 backport PR created✅ Backport PR branch: Backported as #6862 🤖 @patchback |
What do these changes do?
cchardet
stopped being maintained a while ago so this patch removesit from the
speedups
extra to keep it helpful. It also makes thesame adjustment in the CI under the most recent CPython versions to
keep the testing going.
Are there changes in behavior for the user?
pip install aiohttp[speedups]
will only requestcchardet
under CPython < 3.10Related issue number
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.