Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass response to WSServerHandshakeError #701

Closed
mattupstate opened this issue Dec 22, 2015 · 6 comments
Closed

Pass response to WSServerHandshakeError #701

mattupstate opened this issue Dec 22, 2015 · 6 comments
Labels
Milestone

Comments

@mattupstate
Copy link

It might be useful to be able to reference the response when capturing a WSServerHandshakeError. The response object also doesn't seem to get closed when the client consumes this error.

@asvetlov
Copy link
Member

I believe you actually need status code and headers only, not the whole response.
See #706 for fix

@asvetlov
Copy link
Member

Fixed by #706

@jeduden
Copy link

jeduden commented Sep 20, 2017

@asvetlov can we re-open this issue ? since ws_connect actually makes troubleshooting connection errors very difficult as the response in our case contains detailed error information.

@asvetlov
Copy link
Member

Please create a new one with detailed description of your problem.

@jeduden
Copy link

jeduden commented Sep 20, 2017

@asvetlov opened #2279

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants