ClientWebSocketResponse with a json method

[greut]

Long story short

I would love to have a json() method next to the data property of a ClientWebSocketResponse.

Expected behaviour

That I can do msg.json() instead of manually json.loads(msg.data) just like the HTTP response.

Actual behaviour

No json()

Steps to reproduce

async with aiohttp.ws_connect(url) as ws:
    while True:
        msg = await ws.receive()

        if msg.tp == aiohttp.MsgType.text:
            print(json.loads(msg.data))
            print(msg.json())
        else:
            print(msg.tp, file=sys.stderr)
            break

Your environment

Python 3.5, Archlinux, GNU/Linux 4.5.1 x86_64

[asvetlov]

Should msg.data be stripped?

[greut]

I don't understand the stripped idea?

Maybe a better way is to deal with it like the receive_str and receive_bytes, adding a receive_json:

master...greut:862-json

[asvetlov]

I mean should receive_json() work like return json.loads(await self.receive_str()) or return json.loads(await self.receive_str().strip()).

And what to do with empty string data?

[greut]

After some use of it, it's hard to beat for msg in ws: simplicity. It's probably not adding much value vs complexity.

[asvetlov]

Fixed by #897

[greut]

@asvetlov Great! Thanks mate.

[asvetlov]

Thanks to @sseg

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.