-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allowed_protocol_schema_set
backwards compat in BaseConnector
#8633
Comments
bdraco
changed the title
Adjust to only allow
Remove Aug 7, 2024
unix://
urls when the UnixConnector
is used which should not be backported since its a breaking change.allowed_protocol_schema_set
backwards compat in BaseConnector
The fix was merged without npipe/tcp/unix in the base connector. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a followup to #8632 (ref #8600)
A future PR should remove
allowed_protocol_schema_set
inBaseConnector
as its only there for backwards compatWe're aware of that. The point is that currently the client just tries a whitelist of protocols, but really the whitelist should depend which connector is being used (http:// won't work if UnixConnector is used, for example).
I guess tcp:// should be added to the list? I'm not aware of this being a recognised URL protocol though, so not sure why that is in use..
Originally posted by @Dreamsorcerer in #8600 (comment)
The text was updated successfully, but these errors were encountered: