Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trace_request_ctx type is too restrictive #9397

Closed
1 task done
layday opened this issue Oct 3, 2024 · 0 comments · Fixed by #9398
Closed
1 task done

trace_request_ctx type is too restrictive #9397

layday opened this issue Oct 3, 2024 · 0 comments · Fixed by #9398
Labels

Comments

@layday
Copy link
Contributor

layday commented Oct 3, 2024

Describe the bug

As of #8620, the request method's trace_request_ctx parameter is typed as taking a Mapping[str, str]. A value of str seems like an odd restriction to impose and other types are used in the wild. Some examples:

To Reproduce

n/a

Expected behavior

That a wider type would be accepted.

Logs/tracebacks

n/a

Python Version

$ python --version
3.12.5

aiohttp Version

$ python -m pip show aiohttp
3.10.8

multidict Version

$ python -m pip show multidict
6.1.0

yarl Version

$ python -m pip show yarl
1.13.1

OS

macOS

Related component

Client

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant