Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return named tuple from WebSocketResponse.can_prepare #1016

Closed
asvetlov opened this issue Jul 29, 2016 · 2 comments
Closed

Return named tuple from WebSocketResponse.can_prepare #1016

asvetlov opened this issue Jul 29, 2016 · 2 comments
Labels
good first issue Good for newcomers outdated

Comments

@asvetlov
Copy link
Member

To allow writing more understandable checks like:

ret = resp.can_prepare(request)
ret.allowed
ret.protocol

allowed field is subject for discussion.

Also it would be good to implement __bool__ method for the class for easy checking:
if resp.can_prepare(request): ...
@asvetlov asvetlov added the good first issue Good for newcomers label Jul 29, 2016
@esaezgil esaezgil mentioned this issue Jul 29, 2016
Merged
3 tasks
@asvetlov
Copy link
Member Author

Fixed by #1020

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asvetlov