Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gunicorn[UVLoop]WebWorker doesn’t follow gunicorn's signal semantics #1201

Closed
hynek opened this issue Sep 21, 2016 · 4 comments
Closed

Gunicorn[UVLoop]WebWorker doesn’t follow gunicorn's signal semantics #1201

hynek opened this issue Sep 21, 2016 · 4 comments
Labels

Comments

@hynek
Copy link
Contributor

hynek commented Sep 21, 2016

Long story short

From http://docs.gunicorn.org/en/latest/signals.html:

QUIT, INT: Quick shutdown
TERM: Graceful shutdown. Waits for workers to finish their current requests up to the graceful timeout.

Gunicorn[UVLoop]WebWorker don’t follow that.

Expected behaviour

Do what the docs say. :)

Actual behaviour

SIGINT and SIGTERM behave the same and perform graceful shutdowns.

Suggested Fix

If I’m not mistaken, it would be enough to remember whether the shutdown is supposed to be graceful or not and based on that perform https://github.com/KeepSafe/aiohttp/blob/8a145e07d56ab0fcccd2caaa5df6bd8699ce250e/aiohttp/worker.py#L81-L86 conditionally.

@1st1
Copy link
Contributor

1st1 commented Oct 5, 2016

This might be related to #1202, please try uvloop 0.5.4.

@hynek
Copy link
Contributor Author

hynek commented Oct 6, 2016

This isn’t related to uvloop; it doesn't work with the vanilla worker either.

@fafhrd91
Copy link
Member

fixed by #1420

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants