We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
From http://docs.gunicorn.org/en/latest/signals.html:
QUIT, INT: Quick shutdown TERM: Graceful shutdown. Waits for workers to finish their current requests up to the graceful timeout.
Gunicorn[UVLoop]WebWorker don’t follow that.
Gunicorn[UVLoop]WebWorker
Do what the docs say. :)
SIGINT and SIGTERM behave the same and perform graceful shutdowns.
If I’m not mistaken, it would be enough to remember whether the shutdown is supposed to be graceful or not and based on that perform https://github.com/KeepSafe/aiohttp/blob/8a145e07d56ab0fcccd2caaa5df6bd8699ce250e/aiohttp/worker.py#L81-L86 conditionally.
The text was updated successfully, but these errors were encountered:
This might be related to #1202, please try uvloop 0.5.4.
Sorry, something went wrong.
This isn’t related to uvloop; it doesn't work with the vanilla worker either.
fixed by #1420
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that new issue.
No branches or pull requests
Long story short
From http://docs.gunicorn.org/en/latest/signals.html:
Gunicorn[UVLoop]WebWorker
don’t follow that.Expected behaviour
Do what the docs say. :)
Actual behaviour
SIGINT and SIGTERM behave the same and perform graceful shutdowns.
Suggested Fix
If I’m not mistaken, it would be enough to remember whether the shutdown is supposed to be graceful or not and based on that perform https://github.com/KeepSafe/aiohttp/blob/8a145e07d56ab0fcccd2caaa5df6bd8699ce250e/aiohttp/worker.py#L81-L86 conditionally.
The text was updated successfully, but these errors were encountered: