Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiohttp.ClientResponse.**mimetype** property #1349

Closed
moden-py opened this issue Oct 29, 2016 · 3 comments
Closed

aiohttp.ClientResponse.**mimetype** property #1349

moden-py opened this issue Oct 29, 2016 · 3 comments
Labels

Comments

@moden-py
Copy link
Contributor

Long story short

It supposed to be a popular use case to get the content's mime type.
Even aiohttp uses the next construction several times(though not always for response):

ctype = self.headers.get(hdrs.CONTENT_TYPE, '').lower()
mtype, stype, _, params = helpers.parse_mimetype(ctype)

Lets add an easy way to get mime type?
aiohttp.helpers.parse_mimetype already done.

Expected behaviour

resp = await client_session.get(url)
async with resp:
    mtype, stype, suffix, params = resp.mimetype

PS

If agree I will make appropriate PR.

@asvetlov
Copy link
Member

aiohttp.web.Request has content_type and charset properties.
I suggest adding the same to aiohttp.ClientResponse.

@asvetlov
Copy link
Member

Fixed by #1352

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants