Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClientResponse().history elements to ClientResponseError #1741

Closed
penguinolog opened this issue Mar 22, 2017 · 6 comments
Closed

Add ClientResponse().history elements to ClientResponseError #1741

penguinolog opened this issue Mar 22, 2017 · 6 comments
Labels

Comments

@penguinolog
Copy link
Contributor

Long story short

During investigation of HTTP client exceptions on big installations, history can provide information about failure reason (incorrect redirect and etc).
De-facto needed fields:
url, code, reason, location if present in headers (all headers is better)

Expected behaviour

Accessible list ClientResponseError().history

Actual behaviour

Currently this information is unavailable.

Proposed solution:

HistoryRecord = namedtuple('HistoryRecord', ('url', 'code', 'reason', 'headers'))
ClientResponseError().history: typing.List[HistoryRecord]
@fafhrd91
Copy link
Member

Let's just add history to exception. Do we really need new type?

@penguinolog
Copy link
Contributor Author

Just following request_info idea.
May I add just response to exception and expose it fields? (like it done in requests).

@fafhrd91
Copy link
Member

request_info is required only because ClientRequest is private class.
ClientResponseError may be raised without response, so exception should have history of interactions and response that is cause of exception or none if there is no one.

@penguinolog
Copy link
Contributor Author

Accepted. Thank you!

@fafhrd91
Copy link
Member

Merged

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants