ClientSession.close deprecated when called directly via run_until_complete(2.2.3)

[litwisha]

Long story short

When you close session directly via loop.run_until_complete(session.close()), it is deprecated.
The reason is that _CoroGuard inherits from _BaseCoroMixin that inherits from collections.abc.Coroutine.
https://github.com/aio-libs/aiohttp/blob/v2.2.3/aiohttp/helpers.py#L108
And when calling loop.run_until_complete(session.close()) then __await__ or __iter__ methods are unreachable, send method is called instead. That's why, self._awaited attribute is not changed to True.

Expected behaviour

Direct closing loop.run_until_complete(session.close()) is not deprecated

Actual behaviour

Direct closing loop.run_until_complete(session.close()) is deprecated

Steps to reproduce

import asyncio  
from aiohttp import ClientSession

loop = asyncio.get_event_loop()

session = ClientSession(loop=loop)
loop.run_until_complete(session.close())

Your environment

OS X 10.12.3
python 3.6.0
aiohttp==2.2.3

[asvetlov]

I pretty sure the issue is fixed by 97db67b and e176536.
https://github.com/aio-libs/aiohttp/blob/master/tests/test_client_session.py#L58-L60 test is finished without any warning

[litwisha]

@asvetlov
no, it is not fixed for py35+.
Here is a negative test for it.
#2077

[litwisha]

@asvetlov
any ideas?

[asvetlov]

Sure :)
This weekend I'll lead a sprint, hope to find a time for making fix.

[asvetlov]

Fixed by @2161
Released in aiohttp 2.2.5

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new