Relax attribute lookup in warning about old-styled middleware

[asvetlov]

For class-based middleware like

class Middleware:
    async def __call__(self, app, handler):
          ...

there is no __name__ attr.
Moreover I could imaging other situations where __name__ doesn't exists.
It breaks web server starting.

Let's change middleware.__name__ to repr(middleware).

Bugfix should be done in 2.3 branch.

[samuelcolvin]

do you want me to do this?

[asvetlov]

Could you do it asap? Otherwise I'll make a fix myself.
Because I'm blocked on switching to new aiohttp release.
Another finding: even if I decorated the method the check doesn't work:

class Middleware:
    @web.middleware
    async def __call__(self, app, handler):
          ...

_prepare_middlewares() should look on __func__ in case of methoddescriptor.

[samuelcolvin]

Sounds like you know what it needs to do and need the fix. Maybe best if you fix it.

[asvetlov]

Deal

[asvetlov]

Fixed by #2341

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new