Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate literalinclude directive for tutorial snippets #2396

Closed
1 of 2 tasks
webknjaz opened this issue Oct 25, 2017 · 6 comments
Closed
1 of 2 tasks

Integrate literalinclude directive for tutorial snippets #2396

webknjaz opened this issue Oct 25, 2017 · 6 comments
Labels
documentation Improvements or additions to documentation enhancement good first issue Good for newcomers need pull request outdated

Comments

@webknjaz
Copy link
Member

webknjaz commented Oct 25, 2017

This issue is a follow-up for #2390 (comment).

Action items:

/cc: @asvetlov

P.S. IDK whether I'd have time for this myself either, but at least it's properly documented now.

@webknjaz webknjaz added documentation Improvements or additions to documentation good first issue Good for newcomers enhancement need pull request Hacktoberfest labels Oct 25, 2017
@jsoucheiron
Copy link
Contributor

First time contributor here. I've added a PR with changes for the tutorials file in the docs. I didn't even try to do the CI part though, hopefully someone with more experience can do that.

Keep the good work, this project is very useful!

@asvetlov
Copy link
Member

Thank you @jsoucheiron

asvetlov pushed a commit that referenced this issue Oct 26, 2017
…#2400)

* Replace copy-pasted code by literalinclude links

* Remove unneded path to str conversion
@asvetlov
Copy link
Member

asvetlov commented Feb 9, 2018

Fixed by #2400

@asvetlov asvetlov closed this as completed Feb 9, 2018
@webknjaz
Copy link
Member Author

webknjaz commented Feb 9, 2018

@asvetlov but it does not include demo testing part

@asvetlov
Copy link
Member

asvetlov commented Feb 9, 2018

Oops.

  1. Personally I have no spare time to add tests
  2. I hope https://github.com/aio-libs/aiohttp-demos will be finished someday and tutorial links will be moved to point on the project

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement good first issue Good for newcomers need pull request outdated
Projects
None yet
Development

No branches or pull requests

3 participants