socket.gaierror (dns error) is not converted to ClientConnectorError

[hellysmile]

Long story short

socket.gaierror should be converted to ClientConnectorError

Expected behaviour

raises ClientConnectorError

Actual behaviour

raises socket.gaierror (for threaded resolver) or OSError (for aiodns resolver)

Steps to reproduce

import aiohttp
import asyncio


async def main():
    async with aiohttp.ClientSession() as session:
        async with session.get('http://notexist.domain') as response:
            return await response.text()


loop = asyncio.get_event_loop()
loop.run_until_complete(main())

Your environment

MacOS 10.12.6
Python 3.6.2 from pyenv

[hellysmile]

What about to extract fix for this from #2410 to separate pull request?

[achimnol]

Similarly, when connecting to an invalid UNIX socket file (e.g., "/var/run/non-existent-socket.sock"), it raises FileNotFoundError which is not converted to aiohttp.ClientOSError.
(refs aio-libs/aiodocker#142)

[hellysmile]

According to unix connector internals, it is another issue. Please submit it separetelly. It requires another fix.

[hellysmile]

Fixed by #2442, it is not in master yet

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new