Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlDispatcher error during constructing of url with trailing slash #266

Closed
imbolc opened this issue Jan 30, 2015 · 6 comments
Closed

UrlDispatcher error during constructing of url with trailing slash #266

imbolc opened this issue Jan 30, 2015 · 6 comments
Labels

Comments

@imbolc
Copy link
Contributor

imbolc commented Jan 30, 2015

It makes urls without trailing slash.It happened after fixing of regex error :)

>>> from aiohttp.web import UrlDispatcher
>>> disp = UrlDispatcher()
>>> disp.add_route('GET', '/hello/{name}/', lambda x: x, name='name')
<DynamicRoute 'name' [GET] /hello/{name} -> <function <lambda> at 0x7ffd8b47b840>
>>> disp['name'].url(parts={'name': 'foo'})
'/hello/foo'
@asvetlov
Copy link
Member

Fixed in master.
@fafhrd91 do you want to postpone a bugfix release for the issue?

@imbolc
Copy link
Contributor Author

imbolc commented Jan 30, 2015

I'm really appreciated :)

On Fri, Jan 30, 2015 at 5:56 PM, Andrew Svetlov notifications@github.com
wrote:

Fixed in master.
@fafhrd91 https://github.com/fafhrd91 do you want to postpone a bugfix
release for the issue?


Reply to this email directly or view it on GitHub
#266 (comment).

@asvetlov
Copy link
Member

:) Thanks for well-formed bug reports!

@fafhrd91
Copy link
Member

@asvetlov 1-3 weeks between bug fix releases unless urgent fix. I'd prefer separate ticket for each release. Ticket and discussion for every major version change

@asvetlov
Copy link
Member

Ok, sounds fine to me.

On Fri, Jan 30, 2015 at 6:51 PM, Nikolay Kim notifications@github.com
wrote:

@asvetlov https://github.com/asvetlov 1-3 between bug fix releases
unless urgent fix. I'd prefer separate ticket for each release. Ticket and
discussion for every major version change


Reply to this email directly or view it on GitHub
#266 (comment).

Thanks,
Andrew Svetlov

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants