[injection] 2.3.8 broke certain regex match patterns

[thehesiod]

Long story short

#2667 causes the following scenario to break:

router.add_get('/v1/grid/{variable}/{interval_type}/{date}', get_grid)

which compiles to:

re.compile('\\/v1\\/grid\\/(?P<variable>[^{}/]+)\\/(?P<interval_type>[^{}/]+)\\/(?P<date>[^{}/]+)')

which causes the following match group:

<class 'tuple'>: ('temp', 'hourly', '2015-01-01T00:00:00%2B00:00')

and with this code that was recently modified in aiohttp:

{key: URL(value, encoded=True).path for key, value in
                    match.groupdict().items()}

yields

{'variable': 'temp', 'interval_type': 'hourly', 'date': '00:00+00:00'}

Expected behaviour

should not strip out the date from the datetime string

Actual behaviour

date is getting stripped out

Steps to reproduce

Your environment

aiohttp 2.3.8
yarl 1.0.0

[asvetlov]

Reproduced.
Will make bugfix release today

[Artimi]

I've encountered the same problem. This code:

import aiohttp.web
import asyncio


async def hello(request):
	name = request.match_info['name']
	return aiohttp.web.Response(text = f'{name}')


app = aiohttp.web.Application()
app.router.add_get('/{name}', hello)

if __name__ == '__main__':
	aiohttp.web.run_app(app)

With this request:

http://0.0.0.0:8080/na:me

results in

me

Expected:

na:me

It is not problem in aiohttp 2.3.7 with yarl <1.0.0

[asvetlov]

Fixed by 2.3.9 release

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new