StreamResponse instances are all equal

[NotSqrt]

Long story short

Since #2494 , StreamResponse inherits collections.MutableMapping.__eq__, which makes them basically all equal.
The implementation in Mapping looks like return dict(self.items()) == dict(other.items()).

This is especially the case for WebSocketResponse : when following https://aiohttp.readthedocs.io/en/stable/faq.html#how-do-i-programmatically-close-a-websocket-server-side, if you use a list instead of a set, it's impossible to remove the correct websocket.

Expected behaviour

>>> from aiohttp.web_ws import WebSocketResponse
>>> r1 = WebSocketResponse()
>>> r2 = WebSocketResponse()
>>> r1 == r2
False
>>> id(r1) == id(r2)
False
>>> r1 is r2
False
>>> hash(r1) == hash(r2)
False

As a rule, a == b implies hash(a) == hash(b). But it's now broken.

Actual behaviour

Since v3.0:

>>> r1 == r2
True
>>> id(r1) == id(r2)
False
>>> r1 is r2
False
>>> hash(r1) == hash(r2)
False

Steps to reproduce

Described above

Your environment

• aiohttp >= 3.0

[asvetlov]

You are right.

def __eq__(self, other):
    return False

could solve the problem, at least I don't see any drawback.
Would you make a Pull Request with the fix?

[NotSqrt]

There you go !

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new