-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing yield from aiohttp/client.py #316
Comments
https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/protocol.py#L654 |
Seems like it returns a coroutine though https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/protocol.py#L685 |
thats fine if we now that we do not want to drain transport buffer. in any case not using |
OK, I see... perhaps a keyword arg can be introduced to avoid returning a coroutine in that situation. The reason I say that is because I get a bunch of warnings when I turn on asyncio debugging (using the following), and it can easily make other legitimate warnings hard to find
|
oh! |
fixed |
Is there supposed to be a yield from in the following statement (request.write)?
https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/client.py#L510
or the latest release (in case master moves)
https://github.com/KeepSafe/aiohttp/blob/v0.15.1/aiohttp/client.py#L517
The text was updated successfully, but these errors were encountered: