Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTD is still showing docs for 3.3 #3221

Closed
hynek opened this issue Aug 27, 2018 · 12 comments · Fixed by #3224
Closed

RTD is still showing docs for 3.3 #3221

hynek opened this issue Aug 27, 2018 · 12 comments · Fixed by #3224
Assignees
@asvetlov @webknjaz
Labels
bug documentation Improvements or additions to documentation infra need pull request outdated

Comments

@hynek
Copy link
Contributor

hynek commented Aug 27, 2018

https://aiohttp.readthedocs.io/ is currently showing the docs for “Current version is 3.3.2.”
@webknjaz
Copy link
Member

Apparently, this is failing because of #3189: https://readthedocs.org/projects/aiohttp/builds/

@webknjaz webknjaz added bug documentation Improvements or additions to documentation infra labels Aug 27, 2018
@webknjaz
Copy link
Member

webknjaz commented Aug 27, 2018 •
edited
Loading

Probably adding requirements_file: requirements/cython.txt to .readthedocs.yml will fix docs build.

@asvetlov
Copy link
Member

Hrr.

Looks like readthedocs ignores Install your project inside a virtualenv using setup.py install option
Technically docs build doesn't need aiohttp installed but this mode is not supported by rtfd.

Will fix it. Thanks for pointing on readthedocs yaml config.

@webknjaz
Copy link
Member

No, it doesn't ignore that, it just has different defaults. Are you referring to the yaml config?

webknjaz added a commit that referenced this issue Aug 28, 2018
@webknjaz
Install requirements in RTD
6763729 
Fixes #3221

Ref: https://docs.rtfd.io/en/latest/yaml-config.html
@webknjaz webknjaz mentioned this issue Aug 28, 2018
Merged
webknjaz added a commit that referenced this issue Aug 28, 2018
@webknjaz
Install requirements in RTD (#3224)
1325fd9 
Fixes #3221

Ref: https://docs.rtfd.io/en/latest/yaml-config.html
@webknjaz webknjaz mentioned this issue Aug 28, 2018
Merged
@webknjaz
Copy link
Member

Fixed by disabling pip install . in RTD: https://readthedocs.org/projects/aiohttp/builds/7699754/

@webknjaz
Copy link
Member

Probably needs to be backported to 3.4

webknjaz added a commit that referenced this issue Aug 28, 2018
@webknjaz
Install requirements in RTD (#3224)
e426f8c 
Fixes #3221

Ref: https://docs.rtfd.io/en/latest/yaml-config.html
webknjaz added a commit that referenced this issue Aug 28, 2018
@webknjaz
Disable installing deps in RTD
df90e62 
Fixes #3221

Ref: https://docs.rtfd.io/en/latest/yaml-config.html
@webknjaz webknjaz mentioned this issue Aug 28, 2018
Merged
webknjaz added a commit that referenced this issue Aug 28, 2018
@webknjaz
Disable installing deps in RTD (#3226)
f76444c 
Fixes #3221

Ref: https://docs.rtfd.io/en/latest/yaml-config.html
@webknjaz
Copy link
Member

@asvetlov backported, but it didn't trigger the build for stable in RTD. Any settings missing?

@webknjaz
Copy link
Member

@asvetlov this probably needs another version pushed: https://docs.readthedocs.io/en/latest/versions.html
maybe 3.4.0.post0?

@asvetlov
Copy link
Member

Thank you.
I'll publish 3.4.1

@asvetlov
Copy link
Member

I did try to disable pip install . by RTD web interface without success.
Config file is obviously much better option

@webknjaz
Copy link
Member

I guess the config's priority is higher (probably)

@dependencies dependencies bot mentioned this issue Aug 29, 2018
Closed
kornicameister referenced this issue in kornicameister/korni-stats-collector Sep 17, 2018
@pyup-bot @kornicameister
Update aiohttp to 3.4.4 (#94)
a3e0b8d 
This PR updates [aiohttp](https://pypi.org/project/aiohttp) from **3.3.2** to **3.4.4**.



<details>
  <summary>Changelog</summary>
  
  
   ### 3.4.4
   ```
   ==================

- Fix installation from sources when compiling toolkit is not available (`3241 &lt;https://github.com/aio-libs/aiohttp/pull/3241&gt;`_)
   ```
   
  
  
   ### 3.4.3
   ```
   ==================

- Add ``app.pre_frozen`` state to properly handle startup signals in sub-applications. (`3237 &lt;https://github.com/aio-libs/aiohttp/pull/3237&gt;`_)
   ```
   
  
  
   ### 3.4.2
   ```
   ==================

- Fix ``iter_chunks`` type annotation (`3230 &lt;https://github.com/aio-libs/aiohttp/pull/3230&gt;`_)
   ```
   
  
  
   ### 3.4.1
   ```
   ==================

- Fix empty header parsing regression. (`3218 &lt;https://github.com/aio-libs/aiohttp/pull/3218&gt;`_)
- Fix BaseRequest.raw_headers doc. (`3215 &lt;https://github.com/aio-libs/aiohttp/pull/3215&gt;`_)
- Fix documentation building on ReadTheDocs (`3221 &lt;https://github.com/aio-libs/aiohttp/pull/3221&gt;`_)
   ```
   
  
  
   ### 3.4.0
   ```
   ==================

Features
--------

- Add type hints (`3049 &lt;https://github.com/aio-libs/aiohttp/pull/3049&gt;`_)
- Add ``raise_for_status`` request parameter (`3073 &lt;https://github.com/aio-libs/aiohttp/pull/3073&gt;`_)
- Add type hints to HTTP client (`3092 &lt;https://github.com/aio-libs/aiohttp/pull/3092&gt;`_)
- Minor server optimizations (`3095 &lt;https://github.com/aio-libs/aiohttp/pull/3095&gt;`_)
- Preserve the cause when `HTTPException` is raised from another exception. (`3096 &lt;https://github.com/aio-libs/aiohttp/pull/3096&gt;`_)
- Add `close_boundary` option in `MultipartWriter.write` method. Support streaming (`3104 &lt;https://github.com/aio-libs/aiohttp/pull/3104&gt;`_)
- Added a ``remove_slash`` option to the ``normalize_path_middleware`` factory. (`3173 &lt;https://github.com/aio-libs/aiohttp/pull/3173&gt;`_)
- The class `AbstractRouteDef` is importable from `aiohttp.web`. (`3183 &lt;https://github.com/aio-libs/aiohttp/pull/3183&gt;`_)


Bugfixes
--------

- Prevent double closing when client connection is released before the
  last ``data_received()`` callback. (`3031 &lt;https://github.com/aio-libs/aiohttp/pull/3031&gt;`_)
- Make redirect with `normalize_path_middleware` work when using url encoded paths. (`3051 &lt;https://github.com/aio-libs/aiohttp/pull/3051&gt;`_)
- Postpone web task creation to connection establishment. (`3052 &lt;https://github.com/aio-libs/aiohttp/pull/3052&gt;`_)
- Fix ``sock_read`` timeout. (`3053 &lt;https://github.com/aio-libs/aiohttp/pull/3053&gt;`_)
- When using a server-request body as the `data=` argument of a client request, iterate over the content with `readany` instead of `readline` to avoid `Line too long` errors. (`3054 &lt;https://github.com/aio-libs/aiohttp/pull/3054&gt;`_)
- fix `UrlDispatcher` has no attribute `add_options`, add `web.options` (`3062 &lt;https://github.com/aio-libs/aiohttp/pull/3062&gt;`_)
- correct filename in content-disposition with multipart body (`3064 &lt;https://github.com/aio-libs/aiohttp/pull/3064&gt;`_)
- Many HTTP proxies has buggy keepalive support.
  Let&#39;s not reuse connection but close it after processing every response. (`3070 &lt;https://github.com/aio-libs/aiohttp/pull/3070&gt;`_)
- raise 413 &quot;Payload Too Large&quot; rather than raising ValueError in request.post()
  Add helpful debug message to 413 responses (`3087 &lt;https://github.com/aio-libs/aiohttp/pull/3087&gt;`_)
- Fix `StreamResponse` equality, now that they are `MutableMapping` objects. (`3100 &lt;https://github.com/aio-libs/aiohttp/pull/3100&gt;`_)
- Fix server request objects comparison (`3116 &lt;https://github.com/aio-libs/aiohttp/pull/3116&gt;`_)
- Do not hang on `206 Partial Content` response with `Content-Encoding: gzip` (`3123 &lt;https://github.com/aio-libs/aiohttp/pull/3123&gt;`_)
- Fix timeout precondition checkers (`3145 &lt;https://github.com/aio-libs/aiohttp/pull/3145&gt;`_)


Improved Documentation
----------------------

- Add a new FAQ entry that clarifies that you should not reuse response
  objects in middleware functions. (`3020 &lt;https://github.com/aio-libs/aiohttp/pull/3020&gt;`_)
- Add FAQ section &quot;Why is creating a ClientSession outside of an event loop dangerous?&quot; (`3072 &lt;https://github.com/aio-libs/aiohttp/pull/3072&gt;`_)
- Fix link to Rambler (`3115 &lt;https://github.com/aio-libs/aiohttp/pull/3115&gt;`_)
- Fix TCPSite documentation on the Server Reference page. (`3146 &lt;https://github.com/aio-libs/aiohttp/pull/3146&gt;`_)
- Fix documentation build configuration file for Windows. (`3147 &lt;https://github.com/aio-libs/aiohttp/pull/3147&gt;`_)
- Remove no longer existing lingering_timeout parameter of Application.make_handler from documentation. (`3151 &lt;https://github.com/aio-libs/aiohttp/pull/3151&gt;`_)
- Mention that ``app.make_handler`` is deprecated, recommend to use runners
  API instead. (`3157 &lt;https://github.com/aio-libs/aiohttp/pull/3157&gt;`_)


Deprecations and Removals
-------------------------

- Drop ``loop.current_task()`` from ``helpers.current_task()`` (`2826 &lt;https://github.com/aio-libs/aiohttp/pull/2826&gt;`_)
- Drop ``reader`` parameter from ``request.multipart()``. (`3090 &lt;https://github.com/aio-libs/aiohttp/pull/3090&gt;`_)
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/aiohttp
  - Changelog: https://pyup.io/changelogs/aiohttp/
  - Repo: https://github.com/aio-libs/aiohttp
</details>
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@asvetlov asvetlov

@webknjaz webknjaz

Labels
bug documentation Improvements or additions to documentation infra need pull request outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install requirements in RTD aio-libs/aiohttp
3 participants
@hynek @asvetlov @webknjaz