Change connector's limit parameter #977
Comments
|
Maybe we could have 900 as default value to be safe, and a warning message when the limit is reached ? |
It's not too safe because the limit is applied on a single host (right?). And there is no limit on number of hosts you can connect using a single session and a number of sessions you can create. So I would prefer something at the order of 10 (In fact I would prefer exactly |
|
As agreed with @asvetlov , I will start setting up a limit of 20 connections by default, but letting this to be changed by passing a new parameter. |
* Git ignore `*.swp` files * Allow `BaseConnector` to be used as a context manager * Set default limit connection to 20 The default was changed from `None` to 20. `None` used to mean that there were no limits at all, so all number of connections were allowed to the same endpoint. Not, when the user does not specify, the default is 20, but it is still possible to set `None`. #977 * Update documentation for the `limit` parameter. In the docs, document the new behaviour of the `limit` parameter, which now defaults to 20, instead of `None`. * Fit doc text in 80 cols.
|
Fixed by #991 |
Now it is
Noneby default (infinite amount of parallel connections).I suggest shrinking the default to large enough but limited value.
The main question is: what the value should be? 10? 100? 1000?
The only thought about default: it should correlate with default number of available file descriptors, which is 1024.
Thus we have a choice between 10-50-100.
Any suggestions?
The text was updated successfully, but these errors were encountered: