Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add params for makefile #183

Open
3 tasks
Arfey opened this issue Apr 16, 2020 · 26 comments · May be fixed by #311
Open
3 tasks

Add params for makefile #183

Arfey opened this issue Apr 16, 2020 · 26 comments · May be fixed by #311
Labels
easy Easy for first pull request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Arfey
Copy link
Member

Arfey commented Apr 16, 2020 •
edited
Loading

Will be great have approach to put some arguments for make test or commands some like this.

For that we need add some like that into Makefile.

# arguments
FIRST_ARG := $(firstword $(MAKECMDGOALS))
ARGS = $(filter-out $@,$(MAKEOVERRIDES) $(MAKECMDGOALS))
MAKEFILE_PATH := $(abspath $(firstword $(MAKEFILE_LIST)))

%:
	@:

and after that add ${ARGS} to our commands

test:
	docker-compose run --rm app-test ${ARGS}

usage

make test -- my_param=some_param othe_param

u need:

  • generate ARGS variable
  • add this variable to all commands which need it
  • describe that into documentation
@Arfey Arfey added help wanted Extra attention is needed good first issue Good for newcomers easy Easy for first pull request labels Apr 16, 2020
@ranveersequeira
Copy link

I'm new in open source.
Can I start to work on this?

@Arfey
Copy link
Member Author

Arfey commented May 8, 2020

Sure. i'll what ur MR 😀

@ranveersequeira
Copy link

I'mean I've just started today.
Do you think I can do that?
Just forked this and checking whole codebase

@Arfey
Copy link
Member Author

Arfey commented May 8, 2020

Who know, but i'll believe in u 😂
I think so this article will help u
https://opensource.com/article/19/7/create-pull-request-github

@ranveersequeira
Copy link

Sir, I mean what i supposed to know to get started?

@Arfey
Copy link
Member Author

Arfey commented May 8, 2020

This task connected only with this file.

https://github.com/aio-libs/create-aio-app/blob/master/create_aio_app/template/%7B%7Bcookiecutter.project_name%7D%7D/Makefile

Here u can see all useful information for contributor.

https://github.com/aio-libs/create-aio-app/blob/master/CONTRIBUTING.md

if that's not what you want to know, please explain better.

@faraz16iqbal
Copy link

Is this issue still open?

@mahendra1290
Copy link

Is this issue still open ?

@mahendra1290
Copy link

Can i work on this ?.

@Arfey
Copy link
Member Author

Arfey commented Jun 25, 2020

sure

@ghost
Copy link

ghost commented Aug 19, 2020

Is this still open? And can I work on this?

@tiago-macedo
Copy link

Yes.

@ghost
Copy link

ghost commented Aug 21, 2020 •
edited by ghost
Loading

Okay. I am a beginner tho in open source. What do I need to do? I have cloned it. And I have tried to run make test on my windows But it is not working.

@Arfey
Copy link
Member Author

Arfey commented Aug 25, 2020

u can pass output from ur terminal and we can try to help with that.

@ghost
Copy link

ghost commented Aug 26, 2020 via email

@Arfey
Copy link
Member Author

Arfey commented Aug 31, 2020

Could u please use GitHub web interface for send screenshot because i can't open maketest.png :(

@marcosmamg
Copy link

Please assign it to me

@Arfey
Copy link
Member Author

Arfey commented Oct 23, 2020

if u have a time then MR welcome

@HenriGourgue
Copy link

I would like to work on this as my first contribution, is it open?

@Arfey
Copy link
Member Author

Arfey commented Jan 25, 2021

sure)

@HenriGourgue
Copy link

I worked on this issue. I've made something like that :
$make upgrade ARGS="test1 test2 test3 test4"

output
docker-compose run --rm riton6_app python3 -m riton6.utils.check-requirements test1 test2 test3 test4

Is it what you were waiting for ?
If it is not, could you please be more specific ?

@HenriGourgue HenriGourgue mentioned this issue Jan 28, 2021
Closed
@PrithviRana1
Copy link

Is this still open?

@Arfey
Copy link
Member Author

Arfey commented Jun 6, 2022

Hi, i think so yes. the version with ARGS= doesn't look like so good solution. in description for this issue we have solution which cover all cases

@ha36d ha36d linked a pull request Oct 30, 2022 that will close this issue
Open
4 tasks
@rawatsushil
Copy link

@Arfey Hey I have done the changes in my local, i would like to create a PR for this

@tesknight
Copy link

is this issue still open?

@tonguegrease
Copy link

New contributor here! If this is still open I'd like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy Easy for first pull request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add params for makefile ha36d/create-aio-app