Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aio-libs/multidict
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 38cbef7c373e3015ff1fceb96ce8c864373cd78b
Choose a base ref
...
head repository: aio-libs/multidict
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 92dddc256f9d0b8ce32f5377f8832e73a5beb071
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Dec 27, 2023

  1. Fix strict-prototypes compile warnings

    hoodmane authored and webknjaz committed Dec 27, 2023
    Copy the full SHA
    fc697bf View commit details
  2. Add a change note for PR #828

    webknjaz committed Dec 27, 2023
    Copy the full SHA
    92dddc2 View commit details
Showing with 11 additions and 3 deletions.
  1. +8 −0 CHANGES/828.contrib.rst
  2. +1 −1 multidict/_multidict.c
  3. +1 −1 multidict/_multilib/iter.h
  4. +1 −1 multidict/_multilib/views.h
8 changes: 8 additions & 0 deletions CHANGES/828.contrib.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Added an explicit ``void`` for arguments in C-function signatures
which addresses the following compiler warning:

.. code-block:: console
warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
-- by :user:`hoodmane`
2 changes: 1 addition & 1 deletion multidict/_multidict.c
Original file line number Diff line number Diff line change
@@ -1695,7 +1695,7 @@ static PyModuleDef multidict_module = {
};

PyMODINIT_FUNC
PyInit__multidict()
PyInit__multidict(void)
{
#if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 9
multidict_str_lower = PyUnicode_InternFromString("lower");
2 changes: 1 addition & 1 deletion multidict/_multilib/iter.h
Original file line number Diff line number Diff line change
@@ -222,7 +222,7 @@ static PyTypeObject multidict_keys_iter_type = {
};

static inline int
multidict_iter_init()
multidict_iter_init(void)
{
if (PyType_Ready(&multidict_items_iter_type) < 0 ||
PyType_Ready(&multidict_values_iter_type) < 0 ||
2 changes: 1 addition & 1 deletion multidict/_multilib/views.h
Original file line number Diff line number Diff line change
@@ -385,7 +385,7 @@ static PyTypeObject multidict_valuesview_type = {


static inline int
multidict_views_init()
multidict_views_init(void)
{
PyObject *reg_func_call_result = NULL;
PyObject *module = PyImport_ImportModule("multidict._multidict_base");