Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug please #3

Open
ozzyst opened this issue Jan 3, 2020 · 5 comments
Open

Fix bug please #3

ozzyst opened this issue Jan 3, 2020 · 5 comments

Comments

@ozzyst
Copy link

ozzyst commented Jan 3, 2020

venv/lib/python3.7/site-packages/aiograph/types/page_list.py:21

pages: List[Page] = ib(factory=list, converter=pages_converter)

@JrooTJunior
Copy link
Member

aiograph requires attrs 19.1.0 because in 19.3.0 attrs API was break backward compatibility.
now you can install it manually. Soon i'll made an code-review and make corresponding changes in data types.

And when aiogram 3.0 will be released i want to rewrite aiograph too using pydantic.

@Yyonging
Copy link
Contributor

i have fixed that in my fork repository. if u want use you can use pip install aiographfix. once i am using that for emergence.

@Olegt0rr
Copy link

i have fixed that in my fork repository. if u want use you can use pip install aiographfix. once i am using that for emergence.

Why don't you make a pull request?

@Yyonging
Copy link
Contributor

i have fixed that in my fork repository. if u want use you can use pip install aiographfix. once i am using that for emergence.

Why don't you make a pull request?

for emergence, i need to finish task quickly. and i am a noob for pull request -,-.
I will try for that.

@Yyonging
Copy link
Contributor

i have fixed that in my fork repository. if u want use you can use pip install aiographfix. once i am using that for emergence.

Why don't you make a pull request?

i have done that, it seems need one to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants