Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install notes / missing dependencies #12

Open
harry-wood opened this issue Jan 27, 2017 · 2 comments
Open

install notes / missing dependencies #12

harry-wood opened this issue Jan 27, 2017 · 2 comments

Comments

@harry-wood
Copy link
Contributor

harry-wood commented Jan 27, 2017

I tried cloning this and running it locally because I was interested in helping develop improvements to the commons-on-osm.php map.

How do we "install" this code or otherwise get it running? We're missing some files in this repo. commons-on-osm.php references geo_param.php here: https://github.com/aiomaster/WIWOSM/blob/master/client/commons-on-osm.php#L16 and there's a reference to a local javascript file here:
https://github.com/aiomaster/WIWOSM/blob/master/client/commons-on-osm.php#L31 which is obviously OpenLayers but... patched?
Should it be checked into this repo or I should download and rename OpenLayers there?

A good place for such install notes would be a README.md file in this repo

@kolossos
Copy link
Collaborator

kolossos commented Jan 29, 2017

Can you describe what you want to do? The point is that is hard to install stuff from WMFlabs on external servers, where you not have access to the wikimedia-databases. So it's sometimes easier to get an account and become a co-maintainer of the project. (Yes all lame excuses that we not have all files on Github.)

I added geo_param.php. JS-files are available on the server.

@harry-wood
Copy link
Contributor Author

harry-wood commented Jan 30, 2017

I just wanted to do front-end tweaks I think. I'll write out some more issues to describe them.

In the meantime you've fixed both those dependency problems actually.

I was able to get a fully functional copy running on a my local machine, pointed at the live server for the geocommons KML. That's all I need for my purposes. Running my own server & database isn't necessary. But a README file explaining some of this would be a good idea. I notice there's a 'server' directory in this repo, but I guess that's for the server end of some other scripts.

Pointing at the live server for the geocommons KML, I had to work around cross-origin request errors to get that working. I made a little php proxy. I could check that file in here but maybe it's not a recommended approach (Otherwise I guess the server might as well have CORS enabled?) I suppose a static test KML file checked in here might work just as well for a lot of dev purposes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants