-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for width modes other than 1/n #12
Comments
This comment has been minimized.
This comment has been minimized.
@diegorozen Thanks for the suggestion! Here are some initial thoughts:
I think the answer to this is - yes.
I think the answer to this is - yes.
Probably. My only hesitation is API clarity, but that's hopefully a solvable problem.
I'm not sure yet. I am a bit concerned about this, as it would require all consumers of I'm going to do some explorations on what the API could look like to get feedback. Thanks again for suggesting this! |
@bryankeller Agree on #1, #2. On #3, why would make a difference for any existing users? Do you rely on specifying a different width to guarantee to cell to be on a new row or this is just an artifact of the current behavior? As you said before, emulating the default flow layout behavior would be what users of the library would expect Thanks again for making this library and sharing it! |
Side note to |
I'd like to suggest also adding one more width mode that follows readable content guide width. This should be handy for displaying text as well as table view-like collection views. |
Can't you use |
Yes, it is possible to do it like that programmatically. However, it is not really an option when using Interface Builder - there is |
Just replying to myself - then the Interface Builder is not quite a good fit for that case. It looks more like a problem with Apple developer toolkit, rather than a problem of this library. |
Currently, all widths are represented as a fraction 1/n of the width. How would you suggest to add support for something like |-- 2/3 --|-- 1/3 --| : Redefining fractionalWidth to use a floating point number, or adding a 'numerator' associated value to that enum?
Thanks!
The text was updated successfully, but these errors were encountered: