Adding template support in qbol operator

[msumit]

No description provided.

[mistercrunch]

PEP8 says 2 lines before class definitions

[mistercrunch]

I feel like all these attributes aren't guaranteed to be present and that the framework will choke trying to template missing attributes. The contract of what one should provide is unclear.

If they are required, they should be explicitly defined in the constructor header (with defaults), and stamped into self in init.py.

[mistercrunch]

I read the way things are organized in the hook and operator and it's a bit messy the way kwargs is passed around. I saw how you overrode the get_attriubte is a bit hacky too. The operator doesn't have a good doc string to compensate for this behavior... Consider making a clearer interface to the operator, or documenting its expected behavior in the doc string.

[msumit]

Hi Maxime,

I do agree with your concerns. Actually we didn't wanted to add dozens of new operators like QuboleHiveOperator, QuboleHadoopOperator etc, so we'd to do hacks like that. If we had individual command operators like I said above, then we could adhere to simple design like the other operators have.

So either I can try to write down the behaviour in more better way, or you can suggest me some alternative approach for supporting templates?

Thanks,
Sumit

[mistercrunch]

👍