Allow specificiation of project in BigQuery Hook methods #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :return: (project, dataset, table) tuple | ||
| """ | ||
| table_split = project_dataset_table.split('.') | ||
| assert len(table_split) == 2 | len(table_split) == 3, \ |
There was a problem hiding this comment.
Should this be 'or' instead of '|'?
|
Looks good. Let me know when you've done local validation, and I'll merge. |
|
Also, please squash commits once you've verified. |
take in source or destination table strings that include projects. For backwards compatibility reasons, the project is not required. This allows for decoupling of the execution of these methods from projects that have the information they access.
criccomini
added a commit
that referenced
this pull request
Mar 9, 2016
Allow specificiation of project in BigQuery Hook methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow bq base cursor methods run_extract, run_copy, run_load to all take in source or destination table strings that include projects.
For backwards compatibility reasons, the project is not required, and will default to the old behavior if not included.
This allows for a decoupling of these methods from the bq project that they are run on.