add error handling for slack api #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rc = json.loads(sc.api_call(self.method, **self.params).decode('utf-8')) | ||
| if not rc['ok']: | ||
| raise AirflowException("Slack API call failed: ({})".format(rc['error'])) | ||
| logging.error("Slack API call failed ({})".format(rc['error'])) |
There was a problem hiding this comment.
this line would never be reached.
abridgett
force-pushed
the
feature/add_error_handling_to_slack_operator
branch
from
b56a5ff
to
f785baf
Compare
|
doh! fixed. I've also rebased onto master due to he params -> api_params change. Hope that was the right thing to do! |
bolkedebruin
added a commit
that referenced
this pull request
Mar 7, 2016
…slack_operator add error handling for slack api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks API return code as per https://api.slack.com/web