Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statuses column on /admin shows only active or most recent dag_runs #975

Merged
merged 2 commits into from
Mar 14, 2016

Conversation

jtschoonhoven
Copy link

@mistercrunch
Copy link
Member

Can you please rename Status to Recent Statuses here:
https://github.com/airbnb/airflow/blob/master/airflow/www/templates/airflow/dags.html#L23

Ideally also add an info tooltip that fully details what is shown in an info bubble right after that:

<span class="glyphicon glyphicon-info-sign" aria-hidden="true" title="Insert verbose description here"></span>

then call .tooltip() in javascript to get the nice looking bootstrap tooltip.

@jtschoonhoven
Copy link
Author

@mistercrunch done. What's up with the tests?

@mistercrunch
Copy link
Member

We get random failures on travis sometimes, I re-triggered it

@mistercrunch
Copy link
Member

Can you add a test that hits that endpoint in here?
https://github.com/airbnb/airflow/blob/master/tests/core.py#L725

@jtschoonhoven
Copy link
Author

@mistercrunch will revisit this in a week or so when I have time.

@bolkedebruin
Copy link
Contributor

@jtschoonhoven Ping. Are you able to update this. Would be great to have this in.

@mistercrunch
Copy link
Member

Oh yes, please rebase and I'll merge!

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.01% when pulling 254d583 on jtschoonhoven:issue-974 into e2f183c on airbnb:master.

@jtschoonhoven
Copy link
Author

@mistercrunch done

bolkedebruin added a commit that referenced this pull request Mar 14, 2016
statuses column on /admin shows only active or most recent dag_runs
@bolkedebruin bolkedebruin merged commit 2e6447b into apache:master Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants