mount: fix broken .parents()
#713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently, I don't have time to look at this deeply. |
|
Thanks! I added the same test case to |
ljharb
approved these changes
Dec 2, 2016
ljharb
changed the title
.parents()
aweary
approved these changes
Dec 2, 2016
| } | ||
|
|
||
| // This function could be called with a number of different things technically, so we need to | ||
| // pass the *right* thing to our internal helper. |
There was a problem hiding this comment.
nit: this comment feels too vague, what are things and what is the right thing?
There was a problem hiding this comment.
This comment is already in master; I just moved the function higher up due to no-use-before-define
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, this is a bug report. Test should pass, but it doesn't.
When elements tree has more than one branch,
.parents()method returns some nodes, which are not parent of the element.