Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug that doesn't update props with lifecycleExperimental: true and sCU: false #807

Merged
merged 1 commit into from
Feb 15, 2017
Merged

Fix a bug that doesn't update props with lifecycleExperimental: true and sCU: false #807

merged 1 commit into from
Feb 15, 2017

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Feb 13, 2017

This PR is to fix #805.
When lifecycleExperimental is true and shouldComponentUpdate returns false, ShallowWrapper should update instances's props with passed props.

I've also added some unit tests for to assert updating props and state and context whether shouldComponentUpdate returns true or not.

@aweary aweary merged commit eff8f1c into enzymejs:master Feb 15, 2017
@koba04
Copy link
Contributor Author

koba04 commented Feb 16, 2017

Thanks!

@koba04 koba04 deleted the fix-update-props-with-lifecycle-experimental branch February 16, 2017 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aweary aweary aweary approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
API: shallow semver: patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Props not updated when shouldComponentUpdate returns false (lifecycleExperimental: true)
3 participants
@koba04 @ljharb @aweary