Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule proposal: unitless px values #12

Open
lencioni opened this issue Feb 7, 2017 · 1 comment
Open

Rule proposal: unitless px values #12

lencioni opened this issue Feb 7, 2017 · 1 comment

Comments

@lencioni
Copy link
Collaborator

lencioni commented Feb 7, 2017

Bad:

{
  paddingLeft: '1px',
}

Good:

{
  paddingLeft: 1,
}

There are some properties that may require the px unit, e.g. lineHeight.

This is similar to #11.

@ljharb
Copy link
Collaborator

ljharb commented Feb 7, 2017

Similarly, it'd be nice to never allow 0 to have a unit attached, since a unit of zero value is meaningless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants