Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Marker with a duration of 0 #2586

Closed
GuillaumeBourge opened this issue Dec 2, 2024 · 1 comment · Fixed by #2600
Closed

Use Marker with a duration of 0 #2586

GuillaumeBourge opened this issue Dec 2, 2024 · 1 comment · Fixed by #2600

Comments

@GuillaumeBourge
Copy link

Link to repo
Brunch master and module : issue-repro-compose

The issue is when we use a lottie json file with markers, we cannot use marker with duration of 0.
Marker with 0 duration = 1 frame and it's usefull if we want a step without animation.
Currently on Android it is playing the full animation from marker frame to file's end without looping even if set explicity

On lottie iOS library it's working well, the animation is paused on the correct frame.

Steps to reproduce the behavior:
Run the module "issue-repro-compose"
the first star is correctly playing the first marker with a duration of 30 frames infinitly
The second star play one time from the marker till the end although this marker has 0 duration

@GuillaumeBourge
Copy link
Author

Hi,
Thanks you for the Fix ! :)
There is still a small issue, in the first loading, the first frame of the lottie appears before lock to the wanted marker.
There is a possibility to avoid it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant