Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FontManager adds redundant span tags to body #1938

Open
nathanbrud opened this issue Jan 12, 2020 · 0 comments · May be fixed by #2890
Open

FontManager adds redundant span tags to body #1938

nathanbrud opened this issue Jan 12, 2020 · 0 comments · May be fixed by #2890

Comments

@nathanbrud
Copy link

Tell us about your environment
MacOS 10.14.4

Browser and Browser Version:
Chrome 79.0.3945.88

What did you do? Please explain the steps you took before you encountered the problem.

  1. Use lottie.loadAnimation().
  2. Span tags are added to body.
  3. Destroy animation / Use another animation
  4. More span tags are added to body even if the animation uses the same font.

What did you expect to happen?
new span tags won't be added for an existing font.

What actually happened? Please include as much relevant detail as possible.
Reloading the animation adds span tags to body without checking if the span to be added exists.

Reproduce here - https://jsfiddle.net/a129eyfL/

After 1st load
Screen Shot 2020-01-12 at 3 00 12 PM

After a few more (see the duplication for Arvo font)
Screen Shot 2020-01-12 at 3 00 41 PM

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant