update(ErrorMessage): Add trace ID link #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tgeo
requested review from
alecklandgraf,
hayes,
milesj and
stefhatcher
as code owners
Tgeo
commented
Apr 22, 2020
| openInNewWindow | ||
| href={Core.settings.traceURL.replace('{{id}}', traceID)} | ||
| > | ||
| <T k="lunar.trace.viewDetails" phrase="View trace details" /> |
There was a problem hiding this comment.
Do I need to do anything with this new phrase?
There was a problem hiding this comment.
Yes you need to add it internally like our other apps.
Tgeo
commented
Apr 22, 2020
| @@ -25,11 +25,6 @@ export function getErrorMessage(error: string | ErrorType, includeCode: boolean | |||
| return message || ''; | |||
| } | |||
|
|
|||
| // istanbul ignore next | |||
| function createRedirectURL(id: string, url?: string) { | |||
There was a problem hiding this comment.
Seemed unnecessary to generate the URL on-the-fly on a Button's onClick when we can just set an href
Size Changes
View raw build statsPrevious (master){
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 563646,
"lib": 706618
},
"forms": {
"esm": 35672,
"lib": 47577
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
}Current{
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 563903,
"lib": 706970
},
"forms": {
"esm": 35672,
"lib": 47577
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
} |
milesj
reviewed
Apr 22, 2020
| <T k="lunar.error.viewDetails" phrase="View error details" /> | ||
| </MutedButton> | ||
| </Spacing> | ||
| )} | ||
|
|
||
| {traceID && ( | ||
| <Spacing top={1}> |
There was a problem hiding this comment.
Buttons shouldn't be stacked. Wrap with ButtonGroup instead.
milesj
reviewed
Apr 22, 2020
| {traceID && ( | ||
| <Spacing top={1}> | ||
| <MutedButton | ||
| inverted |
There was a problem hiding this comment.
Can you also make them small.
|
@milesj feedback addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @milesj @stefhatcher @hayes @alecklandgraf
Description
traceURLsettingtrace_idproperty fromErrorMessagefor link for more info on that trace IDButtonto aLink(no need for it to be a button that I can think of - don't need to generate the URL "on the fly" when the button is clicked, we can use a plain anchor tag)Motivation and Context
Allow better debugging when a
trace_idis present in anErrorpassed toErrorMessagecomponent.Testing
Added tests. Ran
sglocally and verified.Screenshots
Checklist