feature(ImageViewer): Add FilterControls component to ImageViewer #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 9, 2020 10:19
added 2 commits
October 9, 2020 10:43
Size Changes
View raw build statsPrevious (master){
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 580467,
"lib": 726903
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
}Current{
"apollo": {
"esm": 10832,
"lib": 14147
},
"app-shell": {
"esm": 12906,
"lib": 19874
},
"composer": {
"esm": 68247,
"lib": 101805
},
"core": {
"esm": 583901,
"lib": 732297
},
"forms": {
"esm": 37350,
"lib": 49298
},
"icons": {
"esm": 156355,
"lib": 205626
},
"layouts": {
"esm": 15298,
"lib": 20770
},
"metrics": {
"esm": 5467,
"lib": 7729
},
"test-utils": {
"esm": 4279,
"lib": 5937
}
} |
mheitman
changed the title
|
@williaster @alecklandgraf PTAL 🙂 |
williaster
reviewed
Nov 20, 2020
| export type FilterControlsProps = { | ||
| /** The current brightness. 1 by default. */ | ||
| brightness?: number; | ||
| /** Callback when brightness changes */ |
| onBrightnessChange: (brightness: number) => void; | ||
| /** The current contrast. 1 by default. */ | ||
| contrast?: number; | ||
| /** Callback when contrast changes */ |
| onContrastChange: (contrast: number) => void; | ||
| /** Size of the icons. */ | ||
| iconSize?: number | string; | ||
| /** Place dropdown menu above */ |
| import useStyles, { StyleSheet } from '../../hooks/useStyles'; | ||
|
|
||
| export type FilterControlsProps = { | ||
| /** The current brightness. 1 by default. */ |
There was a problem hiding this comment.
might be worth mentioning what the valid range of brightness values is?
| brightness?: number; | ||
| /** Callback when brightness changes */ | ||
| onBrightnessChange: (brightness: number) => void; | ||
| /** The current contrast. 1 by default. */ |
There was a problem hiding this comment.
might be worth mentioning what the valid range of contrast values is?
|
@williaster updated the comments -- PTAL! |
williaster
approved these changes
Nov 23, 2020
added 2 commits
November 23, 2020 17:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @williaster @alecklandgraf
Description
This adds filters to the
ImageViewercomponent to adjust image brightness and contrast to complement the existingRotateControlsandZoomControls.Motivation and Context
This will be used to further enhance image editing capabilities in the
ImageViewer.Testing
Local storybook
Screenshots
High brightness:
Low brightness:
Checklist