-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a readOnly prop to the SingleDatePicker #501
Conversation
This LGTM, but it needs a rebase (to remove the merge commit) |
Ok, I think I've done the rebase properly. Let me know if not. |
I think if we're going to add this to the Also, I do think we'll be paying some attention to revamping the inputs in the near future so that will likely help work on the problems this prop is trying to solve. |
@erin-doyle no, there's still merge commits in the PR. Assuming |
…to be set as readOnly (addresses #496)
…o be set as readOnly (addresses #496)
Ok, I've rebased (sorry about that, I am not too strong with the git-fu yet 😜 ) and added the prop to DateRangePicker. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol pass-through props. Looks great!
Great, thanks! 😄 |
Woo I'll do a release shortly after I get this one other PR in :) |
This will allow the DateInput to be set as readOnly (addresses #496).