Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol Instances Go Missing When Rendering Plugin #128

Closed
arahansen opened this issue Jun 24, 2017 · 0 comments
Closed

Symbol Instances Go Missing When Rendering Plugin #128

arahansen opened this issue Jun 24, 2017 · 0 comments

Comments

@arahansen
Copy link

This issue is the same one that was described here: #53 (comment)

Expected behavior:
Symbols that have been updated, but their name has not changed should not break references to existing instances of that symbol.

Observed behavior:
Making changes to a symbol will cause instantiations of that symbol to go missing.

How to reproduce:

  1. generate a symbol from react-sketchapp
  2. put the symbol that is now in sketch on a page
  3. update the component in code
  4. npm run render picks up the change and pushes the change to sketch
  5. the symbol you put on the page in step 2 now is "missing"

Sketch version:
43

Please attach screenshots, a zip file of your project, and/or a link to your github project
Example Code:

import { View, Text, makeSymbol, injectSymbols } from 'react-sketchapp'
import React from 'react'

const H1Container = () => <View><Text>Some other Text</Text></View>
H1Container.displayName = 'H1'

makeSymbol(H1Container)

export default context => {
  injectSymbols(context)
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants