Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.0beta.0 release seems to break paragraph spacing support #389

Closed
lessthanzero opened this issue Sep 26, 2018 · 4 comments · Fixed by #390
Closed

3.0.0beta.0 release seems to break paragraph spacing support #389

lessthanzero opened this issue Sep 26, 2018 · 4 comments · Fixed by #390

Comments

@lessthanzero
Copy link
Contributor

Tested out v3.0.0beta.0 and it seems that paragraphSpacing being properly parsed (logged hacksforJSONImpl.js file) doesn't end up in generated .sketch file, thus not being displayed correctly at all.
@mathieudutour
Copy link
Collaborator

when generating a sketch file with node or running it as a plugin?

@lessthanzero
Copy link
Contributor Author

@mathieudutour when running as a plugin

@mathieudutour mathieudutour mentioned this issue Sep 26, 2018
Merged
@mathieudutour
Copy link
Collaborator

Should be fixed in v3.0.0-beta.1

@lessthanzero
Copy link
Contributor Author

Indeed it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add support for paragraph spacing on sketch >= 49 airbnb/react-sketchapp
2 participants
@lessthanzero @mathieudutour