Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opacity on Text Views #43

Closed
ServusJon opened this issue Apr 27, 2017 · 2 comments
Closed

Opacity on Text Views #43

ServusJon opened this issue Apr 27, 2017 · 2 comments

Comments

@ServusJon
Copy link

Opacity change on text views are not working for me.
Anyone else experience that?

@jemgold
Copy link
Contributor

jemgold commented Apr 27, 2017

Looks like we missed it and from ViewRenderer & ImageRenderer too.

I won't have time to fix it until next week at the earliest, but it should be a fun starter contribution if anyone has time to look on it.

In the meantime, you should be able to use rgba / hsla colors / backgroundColors etc

TODO:

  • Make a minimal Sketch file with opacity on the layers
  • use something like copy-sketch-json to inspect the output and find where opacity is set
  • find the corresponding function in src/jsonUtils and add it in
  • also submit a PR to sketchapp-json-flow-types fixing it

@dchen
Copy link
Collaborator

dchen commented May 1, 2017

I'm working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants