Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSS interface #150

Open
samsch opened this issue Jun 17, 2018 · 4 comments
Open

JSS interface #150

samsch opened this issue Jun 17, 2018 · 4 comments

Comments

@samsch
Copy link

samsch commented Jun 17, 2018

The linked JSS interface in the README is not a usable npm package, released, or maintained.

oliviertassinari/react-with-styles-interface-jss#3

Perhaps a note should be added to readme to state as such? It's a bit misleading, and sent me on a bit of a chase to make react-with-styles (for react-dates) work with MUI's JSS.

@ljharb
Copy link
Collaborator

ljharb commented Jun 17, 2018

That's unfortunate; based on oliviertassinari/react-with-styles-interface-jss#3 (comment) we shouldn't be listing it at all.

@oliviertassinari, would you be willing to hand over the npm name if you're not interested in maintaining a package with it? That way, if others want to fork and improve yours, or write a replacement, they're able to do so.

@oliviertassinari
Copy link

oliviertassinari commented Jun 18, 2018

Yes sure. I have been working on a custom wrapper on top of JSS since then (@material-ui/core/styles) that can be used standalone.

@ljharb
Copy link
Collaborator

ljharb commented Jun 18, 2018

Thanks, if you want to npm owner add airbnb then we can coordinate with whoever wants to work on it.

@oliviertassinari
Copy link

npm info react-with-styles-interface-jss

maintainers:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants