Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with HMR #36

Open
toddw opened this issue Dec 2, 2016 · 3 comments
Open

Issues with HMR #36

toddw opened this issue Dec 2, 2016 · 3 comments
Labels

Comments

@toddw
Copy link

toddw commented Dec 2, 2016

When using react-with-styles and hot-module-replacement, the styles object passed in by props is not updating without a full page refresh.

@lencioni
Copy link
Collaborator

lencioni commented Dec 2, 2016

Thanks for the report! I'd be happy to review a PR that fixes this.

@lencioni lencioni added the bug label Dec 2, 2016
@mikefowler
Copy link
Contributor

mikefowler commented Jan 6, 2017

@toddw, I recently upgraded a personal project to use React Hot Loader 3 (upgrade example) and react-with-styles does seem to be working with HMR. Maybe give that a shot?

@scho7623
Copy link

scho7623 commented Sep 5, 2018

I'm facing the same issue as @toddw. Styling directly with aphrodite, hot module replacement (HMR) works as expected, and updates the style, but with react-with-styles, HMR seems to be broken and styles prop is not getting updated, thus not updating style as expected. Does react-with-styles do anything special to handle HMR? Or is something out of react-with-styles broken?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants