Display full table name (schema + name) if possible. (#1728)

superset/models.py

@@ -435,7 +435,8 @@ def __repr__(self):
 
     @property
     def table_names(self):
-        return ", ".join({"{}".format(s.datasource) for s in self.slices})
+        return ", ".join(
+            {"{}".format(s.datasource.name) for s in self.slices})
 
     @property
     def url(self):
@@ -896,17 +897,17 @@ class SqlaTable(Model, Queryable, AuditMixinNullable, ImportMixin):
             name='_customer_location_uc'),)
 
     def __repr__(self):
-        return self.table_name
+        return self.name
 
     @property
     def description_markeddown(self):
         return utils.markdown(self.description)
 
     @property
     def link(self):
-        table_name = escape(self.table_name)
+        name = escape(self.name)
         return Markup(
-            '<a href="{self.explore_url}">{table_name}</a>'.format(**locals()))
+            '<a href="{self.explore_url}">{name}</a>'.format(**locals()))
 
     @property
     def schema_perm(self):
@@ -920,7 +921,9 @@ def get_perm(self):
 
     @property
     def name(self):
-        return self.table_name
+        if not self.schema:
+            return self.table_name
+        return "{}.{}".format(self.schema, self.table_name)
 
     @property
     def full_name(self):

superset/views.py

@@ -701,7 +701,7 @@ def pre_add(self, table):
                 "Table [{}] could not be found, "
                 "please double check your "
                 "database connection, schema, and "
-                "table name".format(table.table_name))
+                "table name".format(table.name))
 
     def post_add(self, table):
         table.fetch_metadata()