-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add-conversions plugin removes blank lines #97
Comments
This is an issue with all plugins that rely on TypeScript transforms. The underlying cause is microsoft/TypeScript#843. I agree it's a major usability issue. I've been thinking about whether it might be possible to munge the transform output by comparing to the original text. That's essentially how I've worked around the problem in some projects I've converted, by using patch manipulation tools before committing to git. |
I'm also having this same issue for the jsdoc plugin. @edsrzf how did you use "patch manipulation tools" to add line breaks back? |
I ended up writing two super simple text plugins that essentially replace |
On a run of ts-migrate against my codebase I noticed that some files were having empty lines removed. This is a deal-breaker as far as usability is concerned. I ran a pass of each plugin on the command-line and discovered that add-conversions is the culprit.
Using ts-migrate 0.1.13 from npm.
The text was updated successfully, but these errors were encountered: