New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global type declaration of ResizeObserver in the visx-responsive package #1104

Closed

MSiddharthReddy opened this issue Mar 12, 2021 · 0 comments · Fixed by #1423

Labels

🤖 typescript @visx/responsive

MSiddharthReddy commented Mar 12, 2021

Since microsoft/TypeScript-DOM-lib-generator#847 has already landed could we remove the global type declarations for ResizeObserver in the visx-responsive package.

This is polluting the global space and is causing issues when we have a ResizeObserver declared locally. Thanks!

williaster added @visx/responsive 🤖 typescript labels

kristw mentioned this issue

fix(responsive): remove ResizeObserver type declaration #1253

Closed

williaster mentioned this issue

fix(responsive): remove global ResizeObserver type declaration #1423

Merged

williaster closed this as completed in #1423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment